[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list
Date: Tue, 15 Mar 2016 15:19:43 +0200

On Tue, Mar 15, 2016 at 02:03:47PM +0100, Gerd Hoffmann wrote:
>   Hi,
> > So here is what I propose instead:
> > 
> > - always initialize it late
> > - sort late, a machine done, not when inserting entries
> > - figure out what the order of existing entries is currently,
> >   and fill an array listing them in this order.
> >   for old machine types, insert the existing entries
> >   in this specific order by using a sorting function:
> What is the point of using *two* ways to sort entries?
> Sure, we can explicitly write down the current order of fw_cfg entries
> and use that to sort them, so order stays as-is even if the
> initialization order changes.  But when going that route I would do that
> *instead* of the alphabetical ordering, for all machine types.
> cheers,
>   Gerd

That's fine too.
The only question is for when we add new fw cfg entries:
do you want to add these to the list as well?

Sorting new entries after old ones will help
avoid future maintainance for this list:
we set it once and never change it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]