[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early tran

From: Sergey Fedorov
Subject: Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults
Date: Thu, 3 Mar 2016 00:36:33 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 02.03.2016 21:04, Sergey Sorokin wrote:
Qemu reports translation fault on 1st level instead of 0th level in case of
AArch64 address translation if the translation table walk is disabled or
the address is in the gap between the two regions.

Signed-off-by: Sergey Sorokin <address@hidden>
  target-arm/helper.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/target-arm/helper.c b/target-arm/helper.c
index 18c8296..09f920c 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -7238,6 +7238,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, 
target_ulong address,
       * support for those page table walks.
      if (arm_el_is_aa64(env, el)) {
+        level = 0;
          va_size = 64;
          if (el > 1) {
              if (mmu_idx != ARMMMUIdx_S2NS) {

I think we'd better set the level variable to 1 for AArch32 in the else clause explicitly and drop its initialization in the beginning of the function. Otherwise it looks like AArch64 is a kind of special case.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]