[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on

From: Peter Maydell
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults
Date: Fri, 4 Mar 2016 15:18:34 +0000

On 4 March 2016 at 15:03, Sergey Sorokin <address@hidden> wrote:
> Do we really need to rearrange the code?
> In pseudo-code the level is set explicitly as well, in case of a fault.

That's why when I originally brought the point up I said
"but I'm not sure it's worth rearranging that code"...
If you want to neaten things up so that we pick the initial
level for faults (0 or 1 depending on va_size) in one place,
then you need to rearrange the code. If you don't want to
rearrange that bit of code you can leave it all as it is, but
you don't get the neat "only one place makes this decision"
structure. You could argue either way and I don't much mind
which we do.

(Incidentally the pseudocode is not always a good guide
for the structure of code; sometimes it makes clear choices,
but sometimes it makes confusing choices.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]