[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/10] net: Convert net filter code to use object pro
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL 06/10] net: Convert net filter code to use object property iterators |
Date: |
Wed, 18 Nov 2015 21:39:34 +0100 |
From: "Daniel P. Berrange" <address@hidden>
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange <address@hidden>
Tested-by: Pavel Fedin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
net/filter.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/filter.c b/net/filter.c
index 326f2b5..1365bad 100644
--- a/net/filter.c
+++ b/net/filter.c
@@ -137,6 +137,7 @@ static void netfilter_complete(UserCreatable *uc, Error
**errp)
Error *local_err = NULL;
char *str, *info;
ObjectProperty *prop;
+ ObjectPropertyIterator *iter;
StringOutputVisitor *ov;
if (!nf->netdev_id) {
@@ -173,7 +174,8 @@ static void netfilter_complete(UserCreatable *uc, Error
**errp)
QTAILQ_INSERT_TAIL(&nf->netdev->filters, nf, next);
/* generate info str */
- QTAILQ_FOREACH(prop, &OBJECT(nf)->properties, node) {
+ iter = object_property_iter_init(OBJECT(nf));
+ while ((prop = object_property_iter_next(iter))) {
if (!strcmp(prop->name, "type")) {
continue;
}
@@ -187,6 +189,7 @@ static void netfilter_complete(UserCreatable *uc, Error
**errp)
g_free(str);
g_free(info);
}
+ object_property_iter_free(iter);
}
static void netfilter_finalize(Object *obj)
--
2.6.2
- [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18, (continued)
- [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 04/10] vl: Convert machine help code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/18
- Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/19
- Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Markus Armbruster, 2015/11/19
[Qemu-devel] [PULL 06/10] net: Convert net filter code to use object property iterators,
Andreas Färber <=
[Qemu-devel] [PULL 08/10] qom: Replace object property list with GHashTable, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 05/10] ppc: Convert spapr code to use object property iterators, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 10/10] MAINTAINERS: Add check-qom-{interface, proplist} to QOM, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 09/10] qom: Clean up assertions to display values on failure, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 07/10] qom: Add a test case for complex property finalization, Andreas Färber, 2015/11/18
Re: [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18, Peter Maydell, 2015/11/19