[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator stru
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration |
Date: |
Thu, 19 Nov 2015 10:49:07 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Daniel P. Berrange" <address@hidden> writes:
> On Thu, Nov 19, 2015 at 10:20:22AM +0100, Markus Armbruster wrote:
>> Andreas Färber <address@hidden> writes:
>>
>> > From: "Daniel P. Berrange" <address@hidden>
>> >
>> > Some users of QOM need to be able to iterate over properties
>> > defined against an object instance. Currently they are just
>> > directly using the QTAIL macros against the object properties
>> > data structure.
>> >
>> > This is bad because it exposes them to changes in the data
>> > structure used to store properties, as well as changes in
>> > functionality such as ability to register properties against
>> > the class.
>> >
>> > This provides an ObjectPropertyIterator struct which will
>> > insulate the callers from the particular data structure
>> > used to store properties. It can be used thus
>> >
>> > ObjectProperty *prop;
>> > ObjectPropertyIterator *iter;
>> >
>> > iter = object_property_iter_init(obj);
>> > while ((prop = object_property_iter_next(iter))) {
>> > ... do something with prop ...
>> > }
>> > object_property_iter_free(iter);
>>
>> I see my review hasn't been addressed, probably because it came late.
>> Would you accept a follow-up patch to bring the iterator into line with
>> existing ones?
>
> I'll write such a patch if you like, but i guess waiting for it to merge
> till 2.6 is no big deal ?
Not even a little deal :)
- [Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators, (continued)
- [Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 04/10] vl: Convert machine help code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/18
- Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/19
- Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Markus Armbruster, 2015/11/19
[Qemu-devel] [PULL 06/10] net: Convert net filter code to use object property iterators, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 08/10] qom: Replace object property list with GHashTable, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 05/10] ppc: Convert spapr code to use object property iterators, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 10/10] MAINTAINERS: Add check-qom-{interface, proplist} to QOM, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 09/10] qom: Clean up assertions to display values on failure, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 07/10] qom: Add a test case for complex property finalization, Andreas Färber, 2015/11/18