[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes |
Date: |
Fri, 6 Nov 2015 09:05:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote:
> On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote:
>> with test
>> while /bin/true ; do
>> virsh snapshot-create rhel7
>> sleep 10
>> virsh snapshot-delete rhel7 --current
>> done
>> with enabled iothreads on a running VM leads to a lot of troubles: hangs,
>> asserts, errors.
That is a case of using libvirt to trigger internal snapshots...
>
> The HMP monitor is legacy and also not used by modern libvirt.
...and libvirt is forced to use HMP for internal snapshots, since we
_still_ haven't exposed internal snapshots as a QMP command.
> I think the affected use cases are restricted to savevm+dataplane and
> HMP+dataplane.
The fact that the commit message calls out a libvirt method of
triggering the bug does mean that it is user-visible, and so it would
qualify as a bug fix even during hard freeze. But I also understand
that taking a large complex series late in the game is not without risk;
and it is not like this is a regression (rather, something that has
never worked bulletproof), right?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 08/11] migration: implement bdrv_all_find_vmstate_bs and bdrv_unlock helpers, (continued)
- [Qemu-devel] [PATCH 08/11] migration: implement bdrv_all_find_vmstate_bs and bdrv_unlock helpers, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 09/11] migration: add missed aio_context_acquire for state writing/reading, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 06/11] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 11/11] monitor: add missed aio_context_acquire into vm_completion call, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 10/11] snapshot: create bdrv_all_create_snapshot helper, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes, Stefan Hajnoczi, 2015/11/06