[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 11/11] monitor: add missed aio_context_acquire into
From: |
Denis V. Lunev |
Subject: |
[Qemu-devel] [PATCH 11/11] monitor: add missed aio_context_acquire into vm_completion call |
Date: |
Wed, 4 Nov 2015 20:19:42 +0300 |
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Luiz Capitulino <address@hidden>
CC: Markus Armbruster <address@hidden>
---
monitor.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 6cd747f..3295840 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3408,13 +3408,18 @@ static void vm_completion(ReadLineState *rs, const char
*str)
readline_set_completion_index(rs, len);
while ((bs = bdrv_next(bs))) {
SnapshotInfoList *snapshots, *snapshot;
+ AioContext *ctx = bdrv_get_aio_context(bs);
+ bool ok = false;
- if (!bdrv_can_snapshot(bs)) {
- continue;
+ aio_context_acquire(ctx);
+ if (bdrv_can_snapshot(bs)) {
+ ok = bdrv_query_snapshot_info_list(bs, &snapshots, NULL) == 0;
}
- if (bdrv_query_snapshot_info_list(bs, &snapshots, NULL)) {
+ aio_context_release(ctx);
+ if (!ok) {
continue;
}
+
snapshot = snapshots;
while (snapshot) {
char *completion = snapshot->value->name;
--
2.5.0
- [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper, (continued)
- [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 07/11] migration: reorder processing in hmp_savevm, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 05/11] snapshot: create bdrv_all_find_snapshot helper, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 08/11] migration: implement bdrv_all_find_vmstate_bs and bdrv_unlock helpers, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 09/11] migration: add missed aio_context_acquire for state writing/reading, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 06/11] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH 11/11] monitor: add missed aio_context_acquire into vm_completion call,
Denis V. Lunev <=
- [Qemu-devel] [PATCH 10/11] snapshot: create bdrv_all_create_snapshot helper, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes, Stefan Hajnoczi, 2015/11/06