[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue |
Date: |
Thu, 5 Nov 2015 07:46:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/05/2015 06:01 AM, Markus Armbruster wrote:
> Vincenzo Maffione <address@hidden> writes:
>
>> Reorganization of struct NetClientOptions caused a compilation failure
>> of the netmap backend. This patch fixes the issue by properly accessing the
>> union field.
>>
>> Signed-off-by: Vincenzo Maffione <address@hidden>
>> ---
>> net/netmap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/netmap.c b/net/netmap.c
>> index 508b829..4197a9c 100644
>> --- a/net/netmap.c
>> +++ b/net/netmap.c
>> @@ -439,7 +439,7 @@ int net_init_netmap(const NetClientOptions *opts,
>> const char *name, NetClientState *peer, Error **errp)
>> {
>> /* FIXME error_setg(errp, ...) on failure */
>> - const NetdevNetmapOptions *netmap_opts = opts->netmap;
>> + const NetdevNetmapOptions *netmap_opts = opts->u.netmap;
>> NetClientState *nc;
>> NetmapPriv me;
>> NetmapState *s;
>
> Broken in commit e4ba22b. Recommend to point to that in the commit
> message. Thanks for cleaning up the mess we made there!
My fault for not compiling netmap code. Does it need specific configure
options?
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/2] Fix compilation of netmap backend, Vincenzo Maffione, 2015/11/05
- [Qemu-devel] [PATCH 2/2] net: netmap: use error_setg_errno() in place of error_report(), Vincenzo Maffione, 2015/11/05
- [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Vincenzo Maffione, 2015/11/05
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Markus Armbruster, 2015/11/05
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Vincenzo Maffione, 2015/11/05
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Vincenzo Maffione, 2015/11/05
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Eric Blake, 2015/11/05
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Vincenzo Maffione, 2015/11/05
- Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue, Markus Armbruster, 2015/11/06