Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

[Markus Armbruster]

Vincenzo Maffione <address@hidden> writes:

> Reorganization of struct NetClientOptions caused a compilation failure
> of the netmap backend. This patch fixes the issue by properly accessing the
> union field.
>
> Signed-off-by: Vincenzo Maffione <address@hidden>
> ---
>  net/netmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netmap.c b/net/netmap.c
> index 508b829..4197a9c 100644
> --- a/net/netmap.c
> +++ b/net/netmap.c
> @@ -439,7 +439,7 @@ int net_init_netmap(const NetClientOptions *opts,
>                      const char *name, NetClientState *peer, Error **errp)
>  {
>      /* FIXME error_setg(errp, ...) on failure */
> -    const NetdevNetmapOptions *netmap_opts = opts->netmap;
> +    const NetdevNetmapOptions *netmap_opts = opts->u.netmap;
>      NetClientState *nc;
>      NetmapPriv me;
>      NetmapState *s;

Broken in commit e4ba22b.  Recommend to point to that in the commit
message.  Thanks for cleaning up the mess we made there!

Reviewed-by: Markus Armbruster <address@hidden>