Re: [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 08/04/2015 11:29 PM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>> 
>>> On 08/04/2015 03:18 AM, Markus Armbruster wrote:
>>>> Reproducer: with
>>>>
>>>>     { 'command': 'user_def_cmd4', 'returns': { 'a': 'int' } }
>>>>
>>>> added to qapi-schema-test.json, qapi-commands.py dies when it tries to
>>>> generate the command handler function
>>>>
>
>>> +++ w/tests/qapi-schema/command-int.json
>>> @@ -1,3 +1,4 @@
>>>  # we reject collisions between commands and types
>>>  { 'command': 'int', 'data': { 'character': 'str' },
>>> -  'returns': { 'value': 'int' } }
>>> +  'returns': 'Foo' }
>>> +{ 'struct': 'Foo', 'data': { 'value': 'int' } }
>> 
>> Okay to simply drop the 'returns' instead?
>> 
>
> Sure, that works too.

Done, with commit message amended:

    Simply outlaw this usage, and drop or dumb down test cases accordingly.