[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args- |
Date: |
Tue, 4 Aug 2015 11:37:03 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> Since every schema entity has 'data', the data- prefix conveys no
> information. These tests actually exercise commands. Only commands
> have arguments, so change the prefix to to args-.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/Makefile | 6
> +++---
> tests/qapi-schema/{data-array-empty.err => args-array-empty.err} | 2 +-
> tests/qapi-schema/{data-unknown.exit => args-array-empty.exit} | 0
> tests/qapi-schema/{data-array-empty.json => args-array-empty.json} | 0
git rename detection doesn't work too well when renaming identical
contents :) Thankfully, it all works out in the end, and the Makefile
changes are the easiest way to review this. And thank goodness that git
compresses renames in patches; this email would have been a lot longer
by traditional diff.
> diff --git a/tests/Makefile b/tests/Makefile
> index 7494582..0f01b5c 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -229,9 +229,9 @@ check-qapi-schema-y := $(addprefix tests/qapi-schema/, \
> redefined-type.json redefined-command.json redefined-builtin.json \
> redefined-event.json command-int.json bad-data.json event-max.json \
> type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \
> - data-array-empty.json data-array-unknown.json data-int.json \
> - data-unknown.json data-member-unknown.json data-member-array.json \
> - data-member-array-bad.json returns-array-bad.json returns-int.json \
> + args-array-empty.json args-array-unknown.json args-int.json \
> + args-unknown.json args-member-unknown.json args-member-array.json \
> + args-member-array-bad.json returns-array-bad.json returns-int.json \
> returns-unknown.json returns-alternate.json returns-whitelist.json \
7 sets of files renamed, including fallout to the changed error messages.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 13/26] tests/qapi-schema: Document events with base don't work, (continued)
- [Qemu-devel] [PATCH 13/26] tests/qapi-schema: Document events with base don't work, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 09/26] qapi-visit: Fix generated code when schema has forward refs, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 06/26] qapi: Drop unused and useless parameters and variables, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 23/26] qapi-commands: Inline gen_marshal_output_call(), Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 11/26] qapi-visit: Fix two name arguments passed to visitors, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 12/26] tests/qapi-schema: Document alternate's enum lacks visit function, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err', Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 26/26] qapi: Generated code cleanup, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args-, Markus Armbruster, 2015/08/04
- Re: [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args-,
Eric Blake <=
- [Qemu-devel] [PATCH 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw, Markus Armbruster, 2015/08/04