[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header
Date: Sat, 18 Jul 2015 18:01:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1

On 18/07/2015 17:37, Peter Crosthwaite wrote:
> > > Would it be possible, or make sense, to do
> > >
> > > #define target_long arm_target_long
> > > #define target_ulong arm_target_ulong
> > >
> > > instead?  This makes prototypes nicer when printed in the debugger with
> > > ptype.  Where could this be done?
> >
> > Hmm, ISTR that this was more or less what v2 was like, so I guess you
> > made the change for a reason. :)  So ignore this.
> I made this change to reduce the cpu.h boiler-plate change pattern and
> it makes the undeffery system consistent with other defs. We could go
> back to the other way to get this debugability if you think it is
> preferrable? Code simplicity vs utility ultimately.

Unless someone else complains, this version is okay with me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]