[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header |
Date: |
Sat, 18 Jul 2015 08:37:54 -0700 |
On Sat, Jul 18, 2015 at 5:37 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 18/07/2015 14:16, Paolo Bonzini wrote:
>>> > +/* target_ulong is the type of a virtual address */
>>> > +#if TARGET_LONG_SIZE == 4
>>> > +#define target_long int32_t
>>> > +#define target_ulong uint32_t
>>> > +#define TARGET_FMT_lx "%08x"
>>> > +#define TARGET_FMT_ld "%d"
>>> > +#define TARGET_FMT_lu "%u"
>>> > +#elif TARGET_LONG_SIZE == 8
>>> > +#define target_long int64_t
>>> > +#define target_ulong uint64_t
>>> > +#define TARGET_FMT_lx "%016" PRIx64
>>> > +#define TARGET_FMT_ld "%" PRId64
>>> > +#define TARGET_FMT_lu "%" PRIu64
>>> > +#else
>>> > +#error TARGET_LONG_SIZE undefined
>>> > +#endif
>> Would it be possible, or make sense, to do
>>
>> #define target_long arm_target_long
>> #define target_ulong arm_target_ulong
>>
>> instead? This makes prototypes nicer when printed in the debugger with
>> ptype. Where could this be done?
>
> Hmm, ISTR that this was more or less what v2 was like, so I guess you
> made the change for a reason. :) So ignore this.
>
I made this change to reduce the cpu.h boiler-plate change pattern and
it makes the undeffery system consistent with other defs. We could go
back to the other way to get this debugability if you think it is
preferrable? Code simplicity vs utility ultimately.
Regards,
Peter
> Paolo
>
- [Qemu-devel] [PATCH v3 08/35] translate-common: Listify tcg_enabled(), (continued)
- [Qemu-devel] [PATCH v3 08/35] translate-common: Listify tcg_enabled(), Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 09/35] core: Convert tcg_enabled() users to tcg_(any|all)_enabled(), Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 10/35] exec-all: Move cpu_can_do_io() to qom/cpu.h, Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 11/35] cputlb: move CPU_LOOP() for tlb_reset() to exec.c, Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 12/35] cputlb: Change tlb_set_dirty() arg to cpu, Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 13/35] include/exec: Move cputlb exec.c defs out, Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 14/35] cpu-common: Define tb_page_addr_t for everyone, Peter Crosthwaite, 2015/07/18
- [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header, Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 17/35] monitor: uninclude cpu_ldst, Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 16/35] cpu-defs: Allow multiple inclusions, Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 19/35] target-*: cpu.h: Undefine core code symbols, Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 18/35] target-*: Don't redefine cpu_exec(), Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 20/35] Makefile.target: Introduce arch-obj, Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 22/35] core: Introduce multi-arch build, Peter Crosthwaite, 2015/07/18
[Qemu-devel] [PATCH v3 21/35] core: virtualise CPU interfaces completely, Peter Crosthwaite, 2015/07/18