[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support |
Date: |
Sat, 20 Jun 2015 23:13:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 12/06/2015 14:57, Stefan Hajnoczi wrote:
> + RockerSwitch *rocker = g_malloc0(sizeof(*rocker));
> + Rocker *r;
> +
> + r = rocker_find(name);
> + if (!r) {
> + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
> + "rocker %s not found", name);
> + return NULL;
Memory leak, please initialize rocker after the "if".
Paolo
> + }
> +
> + rocker->name = g_strdup(r->name);
- [Qemu-devel] [PULL 07/16] main-loop: Drop qemu_set_fd_handler2, (continued)
- [Qemu-devel] [PULL 07/16] main-loop: Drop qemu_set_fd_handler2, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 08/16] alsaaudio: Remove unused error handling of qemu_set_fd_handler, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 09/16] oss: Remove unused error handling of qemu_set_fd_handler, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 10/16] xen_backend: Remove unused error handling of qemu_set_fd_handler, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 11/16] event-notifier: Always return 0 for posix implementation, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 12/16] iohandler: Change return type of qemu_set_fd_handler to "void", Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 13/16] rocker: Add support for phys name, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 15/16] rocker: bring link up/down on PHY enable/disable, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 14/16] rocker: update tests using hw-derived interface names, Stefan Hajnoczi, 2015/06/12
- [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support, Stefan Hajnoczi, 2015/06/12
- Re: [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 00/16] Net patches, Peter Maydell, 2015/06/12