Re: [Qemu-devel] [PATCH 4/4] qmp/hmp: add rocker device support

[Paolo Bonzini]

On 14/05/2015 08:06, address@hidden wrote:
> +    case ROCKER_OF_DPA_GROUP_TYPE_L2_REWRITE:
> +        ngroup->has_index = true;
> +        ngroup->index = ROCKER_GROUP_INDEX_LONG_GET(group->id);
> +        ngroup->has_group_id = true;
> +        ngroup->group_id = group->l2_rewrite.group_id;
> +        if (group->l2_rewrite.vlan_id) {
> +            ngroup->has_set_vlan_id = true;
> +            ngroup->set_vlan_id = ntohs(group->l2_rewrite.vlan_id);
> +        }
> +        break;

Misplaced break?

Paolo

> +        if (memcmp(group->l2_rewrite.src_mac.a, zero_mac.a, ETH_ALEN)) {
> +            ngroup->has_set_eth_src = true;
> +            ngroup->set_eth_src =
> +                qemu_mac_strdup_printf(group->l2_rewrite.src_mac.a);
> +        }
> +        if (memcmp(group->l2_rewrite.dst_mac.a, zero_mac.a, ETH_ALEN)) {
> +            ngroup->has_set_eth_dst = true;
> +            ngroup->set_eth_dst =
> +                qemu_mac_strdup_printf(group->l2_rewrite.dst_mac.a);
> +        }
> +    case ROCKER_OF_DPA_GROUP_TYPE_L2_FLOOD: