[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail() |
Date: |
Fri, 19 Jun 2015 15:18:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 13.06.2015 um 13:18 schrieb Markus Armbruster:
>> It's a perfectly sensible helper function.
>
> But only in the current state. Once/if we just set realized=true on
> /machine level, then no other helper functions will need to set it, as
> pointed out in the following paragraph.
>
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>> include/hw/qdev-core.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
>> index 5789b91..fbfc741 100644
>> --- a/include/hw/qdev-core.h
>> +++ b/include/hw/qdev-core.h
>> @@ -65,8 +65,6 @@ struct VMStateDescription;
>> * Operations depending on @props static properties should go into @realize.
>> * After successful realization, setting static properties will fail.
>> *
>> - * As an interim step, the #DeviceState:realized property is set by
>> deprecated
>> - * function qdev_init_nofail().
>> * In the future, devices will propagate this state change to their children
>> * and along busses they expose.
>> * The point in time will be deferred to machine creation, so that values
>
> Nack to the patch as is. I would be much more open to it if you just
> removed the word "deprecated" rather than the full paragraph explaining
> where it is currently set.
I can certainly do that. May I add your R-by then?
- [Qemu-devel] [PATCH v2 0/7] qdev: Mostly wean off QError, Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 4/7] qdev-monitor: Fix check for full bus, Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 6/7] qdev-monitor: Propagate errors through set_property(), Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop, Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail(), Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive(), Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 5/7] qdev-monitor: Convert qbus_find() to Error, Markus Armbruster, 2015/06/13
- [Qemu-devel] [PATCH v2 7/7] qdev-monitor: Propagate errors through qdev_device_add(), Markus Armbruster, 2015/06/13