qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop
Date: Fri, 19 Jun 2015 14:36:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

Hi Markus,

Could you please add a verbose rationale here like "qdev_init() does not
propagate the Error* and should be replaced by ..."?

Am 13.06.2015 um 13:18 schrieb Markus Armbruster:
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  hw/core/qdev.c         | 47 ++++++++++++++++-------------------------------
>  include/hw/qdev-core.h |  3 +--
>  2 files changed, 17 insertions(+), 33 deletions(-)

Otherwise,

Reviewed-by: Andreas Färber <address@hidden>

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]