Re: [Qemu-devel] [PATCH v4 0/2] semihosting: clean up and add --semihosting-config arg

[Leon Alrae]

On 26/05/2015 17:03, Leon Alrae wrote:
> v4:
> * add semihosting_get_cmdline() and update arm-semi.c to support new option
> * for backward compatibility use -kernel/-append to initialize 
> semihosting.argv
> * update qemu doc to describe the interaction between arg and -kernel/-append

I believe this patchset addressed all the issues raised so far concerning the
--semihosting-config arg option.

As far as semihosting_get_cmdline() goes, at the moment it's used only by ARM
semihosting. I'm not familiar with this API, but if it doesn't mandate any
specific quoting, then I think we should keep the implementation in QEMU free
from any assumptions about guest code and it should be up to the user to pass
an understandable by the guest string. Therefore semihosting_get_cmdline()
returns the same string (i.e. a.out foo "bar baz") for the following inputs:

qemu-system-arm ... -kernel a.out -append 'foo "bar baz"'
qemu-system-arm ... -semihosting-config arg='a.out foo "bar baz"'
qemu-system-arm ... -semihosting-config arg=a.out,arg=foo,arg='"bar baz"'

Do you think there is anything missing or requiring further clarification that
is stopping us from applying these changes? It would be great to sort this out
as MIPS UHI patches rely on these changes.

Thanks,
Leon