|
From: | Michael Tokarev |
Subject: | Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind |
Date: | Fri, 29 May 2015 09:18:35 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
28.05.2015 15:19, Mark Cave-Ayland wrote: [] > The FCode ROMs supplied for CG3/TCX are used to both initialise various > DT entries for the graphic adapters and also provide a minimal driver to > allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot. > > I'd say at the moment the error should be fatal, [...] So it looks like some exit(1) or similar is missing after error_report() in these cases, which should be added :) Thanks! /mjt
[Prev in Thread] | Current Thread | [Next in Thread] |