[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache ent
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time |
Date: |
Thu, 28 May 2015 19:03:08 +0200 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Thu 28 May 2015 06:44:55 PM CEST, Kevin Wolf wrote:
>> Yeah, I'm not sure such duplication helps. I'd still like it
>> reported somewhere, though, as it is nice to query that a requested
>> setting is actually working.
>
> This isn't duplicated information. You can have ImageInfoSpecificQCow2
> show lazy_refcounts=off because that is what the image file contains,
> but the real value in effect could be lazy_refcounts=on.
That's right, ImageInfoSpecificQCow2 returns the value from the header
(s->compatible_features), not the runtime value (s->use_lazy_refcounts).
I think I'll resend the patch without the ImageInfo change. Querying the
runtime values is a task on its own.
Berto
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, (continued)
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Eric Blake, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Max Reitz, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Alberto Garcia, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Max Reitz, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Alberto Garcia, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Kevin Wolf, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time,
Alberto Garcia <=