[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache ent
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time |
Date: |
Thu, 28 May 2015 17:30:50 +0200 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Thu 28 May 2015 05:23:40 PM CEST, Max Reitz wrote:
>>>> Can we mark the parameter optional, and only provide it when it is
>>>> non-zero? That way, qemu-img (which cannot set an interval) will
>>>> not report it, and the only time it will appear is if it was set as
>>>> part of opening the block device under qemu.
>>> That sounds good.
>> But what do we do with the other parameters (refcount-cache-size,
>> l2-cache-size)? We cannot have the same solution there because they
>> don't belong to the image file either, and they're never going go be
>> zero.
> Of course, the simplest solution is to worry about cache-clean-interval
> for now and worry about the cache sizes later… But that basically means
> "We'll never worry about them unless someone complains", so…
My worry is that the solution works in this case because the default
value happens to be 0 and means "disabled", so it makes sense, but it
doesn't work in general with other parameters, so we would be adding
something that we know it's ad-hoc.
Berto
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, (continued)
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Eric Blake, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Max Reitz, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Alberto Garcia, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Max Reitz, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time,
Alberto Garcia <=
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Eric Blake, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Kevin Wolf, 2015/05/29
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Kevin Wolf, 2015/05/28
- Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time, Alberto Garcia, 2015/05/28