[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction of the v1.6 ISA |
Date: |
Thu, 21 May 2015 10:20:49 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/13/2015 02:45 AM, Bastian Koppelmann wrote:
> Signed-off-by: Bastian Koppelmann <address@hidden>
> ---
> target-tricore/translate.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
> + case OPC1_16_SRC_MOV_E:
> + if (tricore_feature(env, TRICORE_FEATURE_16)) {
> + tcg_gen_movi_tl(cpu_gpr_d[r1], const4);
> + tcg_gen_sari_tl(cpu_gpr_d[r1+1], cpu_gpr_d[r1], 31);
You could sign-extend here at translation time, but it's also true that the
optimizer will handle this.
r~
- [Qemu-devel] [PATCH 00/10] TriCore v1.6.1 ISA and missing v1.6 instructions, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 10/10] target-tricore: add RR_DIV and RR_DIV_U instructions of the v1.6 ISA, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 04/10] target-tricore: add CMPSWP instructions of the v1.6.1 ISA, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction of the v1.6 ISA, Bastian Koppelmann, 2015/05/13
- Re: [Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction of the v1.6 ISA,
Richard Henderson <=
- [Qemu-devel] [PATCH 08/10] target-tricore: add FCALL instructions of the v1.6 ISA, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 02/10] target-tricore: introduce ISA v1.6.1 feature, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 09/10] target-tricore: add FRET instructions of the v1.6 ISA, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 07/10] target-tricore: add SYS_RESTORE instruction of the v1.6 ISA, Bastian Koppelmann, 2015/05/13
- [Qemu-devel] [PATCH 06/10] target-tricore: add RR_CRC32 instruction of the v1.6.1 ISA, Bastian Koppelmann, 2015/05/13