[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/31] vl: allow full-blown QemuOpts syntax for
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 10/31] vl: allow full-blown QemuOpts syntax for -global |
Date: |
Tue, 19 May 2015 18:40:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 19/05/2015 18:30, Markus Armbruster wrote:
> Restrictions on driver and property names in the shorthand syntax
> driver.property=value before the patch:
>
> * Both are at most 63 characters long, no whitespace
>
> * Driver name cannot contain '.'
>
> * Property name cannot contain '='
>
> After the patch, we additionally have:
>
> * Driver name cannot contain '='.
>
> Okay as long as no such driver name exists. Have you checked?
Good catch! I now have.
I've grepped for
- \\..*\".*=.*\",
- TYPE_.*\".*=.*\"
with no hits.
> Please spell out the new restriction in the commit message.
Will do.
>> @@ -186,6 +188,9 @@ qemu-system-i386 -global
>> ide-drive.physical_block_size=4096 -drive file=file,if=
>> In particular, you can use this to set driver properties for devices which
>> are
>> created automatically by the machine model. To create a device which is not
>> created automatically and set properties on it, use address@hidden
>> +
>> +The two syntaxes are equivalent. The longer one works for drivers whose
>> name
>> +contains a dot.
>> ETEXI
>>
>> DEF("boot", HAS_ARG, QEMU_OPTION_boot,
>
> I'd explain this as follows:
>
> -global @address@hidden@var{value} is shorthand for -global
> address@hidden,address@hidden,address@hidden The
> longhand syntax works even when @var{driver} contains a dot.
Will do.
Paolo
- [Qemu-devel] [PATCH 05/31] target-i386: mask NMIs on entry to SMM, (continued)
- [Qemu-devel] [PATCH 05/31] target-i386: mask NMIs on entry to SMM, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 06/31] target-i386: set G=1 in SMM big real mode selectors, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 07/31] pflash_cfi01: change big-endian property to BIT type, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 04/31] target-i386: Use correct memory attributes for ioport accesses, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 08/31] pflash_cfi01: change to new-style MMIO accessors, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 03/31] target-i386: Use correct memory attributes for memory accesses, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 10/31] vl: allow full-blown QemuOpts syntax for -global, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 09/31] pflash_cfi01: add secure property, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 12/31] vl: run "late" notifiers immediately, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 13/31] target-i386: create a separate AddressSpace for each CPU, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 11/31] qom: add object_property_add_const_link, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 14/31] hw/i386: add a separate region that tracks the SMRAME bit, Paolo Bonzini, 2015/05/11
- [Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM, Paolo Bonzini, 2015/05/11