Re: [Qemu-devel] [PATCH 1/3] tcg: Merge memop and mmu_idx parameters to qemu_ld/st

[Peter Maydell]

On 13 May 2015 at 20:09, Richard Henderson <address@hidden> wrote:
> At the tcg opcode level, not at the tcg-op.h generator level.
> This requires minor changes through all of the tcg backends,
> but none of the cpu translators.
>
> Signed-off-by: Richard Henderson <address@hidden>

> diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
> index fb2339d..10affab 100644
> --- a/tcg/tci/tcg-target.c
> +++ b/tcg/tci/tcg-target.c
> @@ -763,9 +763,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, 
> const TCGArg *args,
>              tcg_out_r(s, *args++);
>          }
>          tcg_out_i(s, *args++);
> -#ifdef CONFIG_SOFTMMU
> -        tcg_out_i(s, *args);
> -#endif
>          break;
>      case INDEX_op_qemu_ld_i64:
>          tcg_out_r(s, *args++);
> @@ -777,9 +774,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, 
> const TCGArg *args,
>              tcg_out_r(s, *args++);
>          }
>          tcg_out_i(s, *args++);
> -#ifdef CONFIG_SOFTMMU
> -        tcg_out_i(s, *args);
> -#endif
>          break;
>      case INDEX_op_qemu_st_i32:
>          tcg_out_r(s, *args++);

Don't you also need a corresponding change in tci.c to make
it only read one argument and split it into memop/mmu_idx ?

-- PMM