[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs |
Date: |
Mon, 30 Mar 2015 22:30:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/29/2015 10:03 AM, Markus Armbruster wrote:
> What happens when I define a member key multiple times in a struct or
> union type?
>
> If I do it directly, the parser rejects the duplicate key in
> get_members(). Covered by tests/qapi-schema/duplicate-key.json.
>
> What if I hide the duplicate in a base type?
>
> If I stick this into qapi-schema-test.json:
>
> { 'type': 'Base', 'data': { 'foo': 'str', 'bar': 'str' } }
> { 'type': 'Clash', 'base': 'Base', 'data': { 'foo': 'int' } }
> { 'command': 'clash', 'data': 'Clash' }
>
> the resulting test-qmp-commands.h declares qmp_clash(), but
> test-qmp-marshal.c doesn't define it. WTF?!?
Nice test; I'll see if I can add a patch on to the end of the series to
flag it. I suspect flat unions have potential for the same issue.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci, (continued)
- [Qemu-devel] [PATCH v5 28/28] qapi: Drop support for inline nested types, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 25/28] qapi: Drop tests for inline nested structs, Eric Blake, 2015/03/24
- Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs, Markus Armbruster, 2015/03/27
- Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs, Markus Armbruster, 2015/03/29
- Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs,
Eric Blake <=