[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs |
Date: |
Sun, 29 Mar 2015 18:03:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
What happens when I define a member key multiple times in a struct or
union type?
If I do it directly, the parser rejects the duplicate key in
get_members(). Covered by tests/qapi-schema/duplicate-key.json.
What if I hide the duplicate in a base type?
If I stick this into qapi-schema-test.json:
{ 'type': 'Base', 'data': { 'foo': 'str', 'bar': 'str' } }
{ 'type': 'Clash', 'base': 'Base', 'data': { 'foo': 'int' } }
{ 'command': 'clash', 'data': 'Clash' }
the resulting test-qmp-commands.h declares qmp_clash(), but
test-qmp-marshal.c doesn't define it. WTF?!?
- [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci, (continued)
- [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 28/28] qapi: Drop support for inline nested types, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 25/28] qapi: Drop tests for inline nested structs, Eric Blake, 2015/03/24
- Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs, Markus Armbruster, 2015/03/27
- Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs,
Markus Armbruster <=