[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migratio
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread |
|
Date: |
Mon, 30 Mar 2015 10:31:06 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 26/03/2015 12:05, Dr. David Alan Gilbert wrote:
>>> > > + qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER);
>>> > > + *old_vm_running = runstate_is_running();
>> >
>> > I think that needs some explanation. Why are you doing a wakeup on
>> > the source host?
> This matches the existing code in migration_thread for the end of precopy;
> Paolo's explanation of what it does is here:
> https://lists.gnu.org/archive/html/qemu-devel/2014-08/msg04880.html
The more I look at it, the more I'm convinced it's working by chance or
not working at all.
Here we probably need to do only the notifier_list_notify +
qapi_event_send_wakeup.
Paolo