qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] qapi: Add optional field


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] qapi: Add optional field "name" to block dirty bitmap
Date: Wed, 11 Mar 2015 15:34:18 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Mar 02, 2015 at 06:19:48PM -0500, John Snow wrote:
> From: Fam Zheng <address@hidden>
> 
> This field will be set for user created dirty bitmap. Also pass in an
> error pointer to bdrv_create_dirty_bitmap, so when a name is already
> taken on this BDS, it can report an error message. This is not global
> check, two BDSes can have dirty bitmap with a common name.
> 
> Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
> be used later when other QMP commands want to reference dirty bitmap by
> name.
> 
> Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  block.c               | 32 +++++++++++++++++++++++++++++++-
>  block/mirror.c        |  2 +-
>  include/block/block.h |  7 ++++++-
>  migration/block.c     |  2 +-
>  qapi/block-core.json  |  4 +++-
>  5 files changed, 42 insertions(+), 5 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: pgpKHqPmOjqDE.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]