[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id |
|
Date: |
Wed, 4 Mar 2015 12:02:31 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Mar 04, 2015 at 03:20:55PM +0100, Andreas Färber wrote:
> Am 04.03.2015 um 03:13 schrieb Eduardo Habkost:
> > The field doesn't need to be inside CPUState, and it is not specific for
>
> You mean CPUX86State or CPUArchState, I guess. :)
>
> > the CPUID instruction, so move and rename it.
> >
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > Reviewed-by: Andreas Färber <address@hidden>
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> Could you please use Class::field syntax for consistency when you apply?
Will fix both issues. Thanks!
--
Eduardo
- Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code, (continued)
[Qemu-devel] [PATCH v4 5/5] target-i386: Require APIC ID to be explicitly set before CPU realize, Eduardo Habkost, 2015/03/03
[Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id, Eduardo Habkost, 2015/03/03