[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id
Date: Wed, 04 Mar 2015 15:20:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

Am 04.03.2015 um 03:13 schrieb Eduardo Habkost:
> The field doesn't need to be inside CPUState, and it is not specific for

You mean CPUX86State or CPUArchState, I guess. :)

> the CPUID instruction, so move and rename it.
> Reviewed-by: Paolo Bonzini <address@hidden>
> Reviewed-by: Andreas Färber <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>

Could you please use Class::field syntax for consistency when you apply?


SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]