Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 01/13/2015 10:50 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  balloon.c | 29 +++++++++++++++--------------
>>  1 file changed, 15 insertions(+), 14 deletions(-)
>> 
>> diff --git a/balloon.c b/balloon.c
>> index 2884c2d..aa30617 100644
>> --- a/balloon.c
>> +++ b/balloon.c
>> @@ -36,6 +36,19 @@ static QEMUBalloonEvent *balloon_event_fn;
>>  static QEMUBalloonStatus *balloon_stat_fn;
>>  static void *balloon_opaque;
>>  
>> +static int have_ballon(Error **errp)
>> +{
>> +    if (kvm_enabled() && !kvm_has_sync_mmu()) {
>> +        error_set(errp, QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
>> +        return 0;
>> +    }
>> +    if (!balloon_event_fn) {
>> +        error_set(errp, QERR_DEVICE_NOT_ACTIVE, "balloon");
>> +        return 0;
>> +    }
>> +    return 1;
>
> Another case where I would have used bool, true, false.

Me too now that you mention it %-)

> Either way,
> Reviewed-by: Eric Blake <address@hidden>

Thanks!