[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use |
Date: |
Wed, 14 Jan 2015 14:51:29 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 01/13/2015 10:50 AM, Markus Armbruster wrote:
>> Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose,
>> probably because adding another error seemed cumbersome overkill.
>> Produces "No spice device has been activated", which is awkward.
>>
>> We've since abandoned our quest for "rich" error objects. Time to
>> undo the damage to this error message. Replace it by "SPICE is not in
>> use".
>>
>> Keep the stupid DeviceNotActive ErrorClass for compatibility, even
>> though Libvirt doesn't use it.
>
> Libvirt has a few places that look explicitly for "DeviceNotActive" when
> deciding how to handle failure reporting; I didn't audit closely enough
> to see if it actually changes behavior if the class were to disappear.
I studied libvirt's use of error classes other than GenericError before
my Christmas break. My findings:
* CommandNotFound: used; libvirt could perhaps rely on query-commands
instead
* DeviceEncrypted: not used (surprise, surprise)
* DeviceNotActive: used with balloon and block jobs, not used with spice
* DeviceNotFound: used to detect active commit support, with
device-list-properties and with qom-list (which isn't about devices at
all)
* KVMMissingCap: used; occurs only with balloon, and it shandled just
like DeviceNotActive
> Your approach in this patch is safest, at any rate.
I'm resigned to keeping these error classes around. I'm still fighting
their proliferation to new code.
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> include/ui/qemu-spice.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 0/9] qmp hmp balloon: Cleanups around error reporting, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 4/9] qmp: Clean up qmp_query_spice() #ifndef !CONFIG_SPICE dummy, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 3/9] hmp: Compile hmp_info_spice() only with CONFIG_SPICE, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 6/9] qmp: Eliminate silly QERR_COMMAND_NOT_FOUND macro, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 7/9] balloon: Inline qemu_balloon(), qemu_balloon_status(), Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros, Markus Armbruster, 2015/01/13
- [Qemu-devel] [PATCH 5/9] qmp: Simplify recognition of capability negotiation command, Markus Armbruster, 2015/01/13
- Re: [Qemu-devel] [PATCH 0/9] qmp hmp balloon: Cleanups around error reporting, Gerd Hoffmann, 2015/01/14