[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backing files |
Date: |
Wed, 26 Nov 2014 09:40:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/26/2014 09:20 AM, Max Reitz wrote:
> When using a relative backing file name, qemu needs to know the
> directory of the top image file. For JSON filenames, such a directory
> cannot be easily determined (e.g. how do you determine the directory of
> a qcow2 BDS directly on top of a quorum BDS?). Therefore, do not allow
> relative filenames for the backing file of BDSs only having a JSON
> filename.
>
> Furthermore, BDS::exact_filename should be used whenever possible. If
> BDS::filename is not equal to BDS::exact_filename, the former will
> always be a JSON object.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 28 ++++++++++++++++++++++------
> block/qapi.c | 7 ++++++-
> include/block/block.h | 5 +++--
> 3 files changed, 31 insertions(+), 9 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/6] block: Relative backing files, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 6/6] iotests: Add test for relative backing file names, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 2/6] block: Get full backing filename from string, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backing files, Max Reitz, 2014/11/26
- Re: [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backing files,
Eric Blake <=
- [Qemu-devel] [PATCH v4 4/6] block: Relative backing file for image creation, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 5/6] block/vmdk: Relative backing file for creation, Max Reitz, 2014/11/26