[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition |
|
Date: |
Wed, 26 Nov 2014 09:39:13 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/26/2014 09:20 AM, Max Reitz wrote:
> CODING_STYLE states the following about braces around blocks:
>
>> The opening brace is on the line that contains the control flow
>> statement that introduces the new block; [...]
>
> This is obviously impossible with multi-line conditions. Therefore,
> CODING_STYLE does not make any clear statement about where to put the
> opening brace after a multi-line condition.
I'll leave review of this one to others (personally, I'm 80:20 against
applying it, but my vote is very weak if you scale it by the percentage
of actual C code contributions existing in the tree under my name - so
I'll live with majority rules).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/6] block: Relative backing files, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition, Max Reitz, 2014/11/26
- Re: [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition,
Eric Blake <=
- [Qemu-devel] [PATCH v4 6/6] iotests: Add test for relative backing file names, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 2/6] block: Get full backing filename from string, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backing files, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 4/6] block: Relative backing file for image creation, Max Reitz, 2014/11/26
- [Qemu-devel] [PATCH v4 5/6] block/vmdk: Relative backing file for creation, Max Reitz, 2014/11/26