Re: [Qemu-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

[Xu, Quan]

> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Tuesday, November 25, 2014 1:19 AM
> To: Xu, Quan; address@hidden
> Cc: address@hidden; address@hidden; address@hidden
> Subject: Re: [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM
> command line options
> 
> On 11/23/2014 09:10 PM, Quan Xu wrote:
> > Signed-off-by: Quan Xu <address@hidden>
> > ---
> >  configure        | 14 ++++++++++++++
> >  hmp.c            |  7 +++++++
> >  qapi-schema.json | 20 ++++++++++++++++++--  qemu-options.hx  | 13
> > +++++++++++--
> >  tpm.c            |  7 ++++++-
> >  5 files changed, 56 insertions(+), 5 deletions(-)
> >
> 
> > +++ b/qapi-schema.json
> > @@ -2855,8 +2855,12 @@
> >  # @passthrough: TPM passthrough type
> >  #
> >  # Since: 1.5
> > +#
> > +# @xenstubdoms: TPM xenstubdoms type
> > +#
> > +# Since: 2.3
> 
> Typically, this would be done as:
> 
> # @passthrough: TPM passthrough type
> #
> # @xenstubdoms: TPM xenstubdoms type (since 2.3) # # Since: 1.5
> 

Thanks  Eric. 
I will modify it as your suggestion in v3.

> as the enum itself was added in 1.5, not 2.3.
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org