[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stu
From: |
Xu, Quan |
Subject: |
Re: [Qemu-devel] [Xen-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options |
Date: |
Wed, 26 Nov 2014 02:03:58 +0000 |
> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Wednesday, November 26, 2014 12:31 AM
> To: Xu, Quan; address@hidden
> Cc: address@hidden; address@hidden; address@hidden
> Subject: Re: [Xen-devel] [Qemu-devel] [v2 1/4] Qemu-Xen-vTPM: Support for
> Xen stubdom vTPM command line options
>
> On 11/25/2014 06:51 AM, Xu, Quan wrote:
> >>
> >> Also, this message was not threaded properly; it appeared as a
> >> top-level thread along with three other threads for its siblings,
> >> instead of all four patches being in-reply-to the 0/4 cover letter.
> >>
> > Thanks Eric.
> >
> > Should I:
> >
> > V2 is version number,
> > 1. $git format-patch --subject-prefix=v2 -ns --cover-letter master
> > Then, edit 0000-cover-letter.patch
>
> Rather than '--subject-prefix=v2', I prefer using '-v2'. The important part
> is
> that you send the mails with 'git send-email' instead of doing it by hand. In
> fact, you can do 'git send-email --annotate -v2 --cover-letter master' and
> skip
> the format-patch altogether, if you are okay saving your cover letter edits to
> the point where you are sending the mails.
>
Thanks Eric.
> >
> > 2. $git format-patch --subject-prefix=v2 -4
> > Then, commit these 4 patch and 0000-cover-letter.patch
>
> I'm not sure what you meant by commit. You aren't adding the *.patch files
> to a repository, but sending them as email.
>
Yes, just but sending them as email.
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org