Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

[Chao Peng]

On Fri, Oct 24, 2014 at 02:01:44PM -0200, Eduardo Habkost wrote:
> On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote:
> > Add AVX512 feature bits, register definition and corresponding
> > xsave/vmstate support.
> > 
> > Signed-off-by: Chao Peng <address@hidden>
> > ---
> [...]

I agree to the cleanup scheme paolo suggested.
And thanks Eduardo for going thru the spec and double checking for
this.

> > @@ -745,6 +829,9 @@ VMStateDescription vmstate_x86_cpu = {
> >          }, {
> >              .vmsd = &vmstate_msr_hyperv_time,
> >              .needed = hyperv_time_enable_needed,
> > +   }, {
> > +            .vmsd = &vmstate_avx512,
> > +            .needed = avx512_needed,
> >          } , {
> >              /* empty */
> 
> The tab character above needs to be replaced by spaces, but the rest
> looks good and matches the Intel docs.
> 
> Reviewed-by: Eduardo Habkost <address@hidden>

If this is the only issue, paolo, could you help on this when you
commit? Thank you.

Chao