[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error info t
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error info to caller |
Date: |
Mon, 29 Sep 2014 09:48:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
zhanghailiang <address@hidden> writes:
> The second parameter of dump_error is unused, but one purpose of
> using this function is to report the error info.
>
> Use error_set to return the error info to the caller.
>
> Signed-off-by: zhanghailiang <address@hidden>
The commit message doesn't explain this patch's benefit clearly.
Suggest:
dump: Propagate errors into qmp_dump_guest_memory()
The code calls dump_error() on error, and even passes it a suitable
message. However, the message is thrown away, and its callers pass
up only success/failure. All qmp_dump_guest_memory() can do is set
a generic error.
Propagate the errors properly, so qmp_dump_guest_memory() can return
a more useful error.
With a commit message like that:
Reviewed-by: Markus Armbruster <address@hidden>