qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 0/2] dump: let dump_error return error reason


From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH v6 0/2] dump: let dump_error return error reason to caller
Date: Sun, 28 Sep 2014 09:18:50 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

Hi,

Ping^2...

Can anyone help reviewing this patch? Luiz? Eric? Markus? Thanks;)

Best regards,
zhanghailiang

On 2014/9/24 8:39, zhanghailiang wrote:
Hi,

  Ping...

Thanks,
zhanghailiang

On 2014/9/19 14:43, zhanghailiang wrote:
Hi,

In original code, Function dump_error ignores its second parameter which 
contains
error reason, it is better to return the error message to the caller.

Here we use error_setg to return the error info to caller.
And at the same time, we turn functions like write_elf64_note() to void,
Because functions shouldn't return an error code _and_ an Error object.
After this modification the code will be more clean.

v5 -> v6
- Don't check *errp directly, if errp is NULL, there will be an error,
   Instead, check a local variable *local_err (Markus Armbruster)
v4 -> v5:
- Turn functions like write_elf64_note() to void (Luiz Capitulino)
v3 -> v4:
- Adjust the errp argument to the end
- Remove trailing '.' in error messages
v2 -> v3:
- Drop the '\n' in the message when call dump_error(Eric Blake)
v1 -> v2:
- Return the error reason to the caller (Luiz Capitulino)

zhanghailiang (2):
   dump: let dump_error return error info to caller
   dump: Don't return error code when return an Error object

  dump.c | 382 +++++++++++++++++++++++++++++++----------------------------------
  1 file changed, 182 insertions(+), 200 deletions(-)











reply via email to

[Prev in Thread] Current Thread [Next in Thread]