Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

[Paolo Bonzini]

Il 24/09/2014 17:21, Benoît Canet ha scritto:
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Benoît Canet <address@hidden>
> ---
>  include/qemu/throttle.h | 2 --
>  include/qemu/timer.h    | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> index 8f9e611..1c639d2 100644
> --- a/include/qemu/throttle.h
> +++ b/include/qemu/throttle.h
> @@ -27,8 +27,6 @@
>  #include "qemu-common.h"
>  #include "qemu/timer.h"
>  
> -#define NANOSECONDS_PER_SECOND  1000000000
> -
>  typedef enum {
>      THROTTLE_BPS_TOTAL,
>      THROTTLE_BPS_READ,
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index 5f5210d..0884e72 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -5,6 +5,8 @@
>  #include "qemu-common.h"
>  #include "qemu/notify.h"
>  
> +#define NANOSECONDS_PER_SECOND  1000000000
> +
>  /* timers */
>  
>  #define SCALE_MS 1000000
> 

Went through all uses, for the two that matter:

util/throttle.c:    leak = (bkt->avg * (double) delta_ns) / 
NANOSECONDS_PER_SECOND;
util/throttle.c:    double wait = extra * NANOSECONDS_PER_SECOND;

the other operand is already double.

Reviewed-by: Paolo Bonzini <address@hidden>