Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

[Benoît Canet]

On Mon, Sep 29, 2014 at 11:54:47PM +0200, Paolo Bonzini wrote:
> Il 29/09/2014 18:04, Benoît Canet ha scritto:
> > On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote:
> >> Il 24/09/2014 17:21, Benoît Canet ha scritto:
> >>> Reviewed-by: Eric Blake <address@hidden>
> >>> Signed-off-by: Benoît Canet <address@hidden>
> >>> ---
> >>>  include/qemu/throttle.h | 2 --
> >>>  include/qemu/timer.h    | 2 ++
> >>>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> >>> index 8f9e611..1c639d2 100644
> >>> --- a/include/qemu/throttle.h
> >>> +++ b/include/qemu/throttle.h
> >>> @@ -27,8 +27,6 @@
> >>>  #include "qemu-common.h"
> >>>  #include "qemu/timer.h"
> >>>  
> >>> -#define NANOSECONDS_PER_SECOND  1000000000
> >>> -
> >>>  typedef enum {
> >>>      THROTTLE_BPS_TOTAL,
> >>>      THROTTLE_BPS_READ,
> >>> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> >>> index 5f5210d..0884e72 100644
> >>> --- a/include/qemu/timer.h
> >>> +++ b/include/qemu/timer.h
> >>> @@ -5,6 +5,8 @@
> >>>  #include "qemu-common.h"
> >>>  #include "qemu/notify.h"
> >>>  
> >>> +#define NANOSECONDS_PER_SECOND  1000000000
> >>> +
> >>>  /* timers */
> >>>  
> >>>  #define SCALE_MS 1000000
> >>>
> >>
> >> Reviewed-by: Paolo Bonzini <address@hidden>
> >>
> >> :)
> > 
> > Two rev by for one commit are better than one but does this belong to
> > the third commit ? :)
> 
> The rev-bys belong to the first and second.  The third's on my list...
> 

I misread (freudian slip) the 20 seconds delta between the two rev-by as 20 min.
20 min was credible but 20 seconds is not despite you being fast :)

Best regards

Benoît

> Paolo
>