Re: [Qemu-devel] [RFC v1 1/6] stm32f205_timer: Add the stm32f205 SoC Timer2 to 5

[Alistair Francis]

On Wed, Sep 10, 2014 at 10:07 PM, Peter Crosthwaite
<address@hidden> wrote:
> On Wed, Sep 10, 2014 at 9:52 AM, Alistair Francis <address@hidden> wrote:
>> On Tue, Sep 9, 2014 at 10:44 PM, Peter Crosthwaite
>> <address@hidden> wrote:
>>> On Tue, Sep 9, 2014 at 6:23 PM, Alistair Francis <address@hidden> wrote:
>>>> This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5
>>>> to QEMU.
>>>>
>>>> Signed-off-by: Alistair Francis <address@hidden>
>>>> ---
>>>> V2:
>>>>  - Small changes to functionality and style. Thanks to Peter C
>>>>  - Rename for the Netduino 2 and it's SoC
>>>>
>
>>>> +#include "hw/timer/stm32f205_timer.h"
>>>> +
>>>> +    DB_PRINT("Read 0x%x\n", (uint) offset);
>>>
>>> HWADDR_PRIx instead of cast.
>>
>> What do you mean by HWADDR_PRIx?
>>
>
> If you want to use a hwaddr in printfery there is a special % format
> for it. Here is an example:
>
> hw/char/serial.c:    DPRINTF("read addr=0x%" HWADDR_PRIx "
> val=0x%02x\n", addr, ret);

I never knew that was there

Thanks,

Alistair

>
> Regards,
> Peter