[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] rng-random: NULL check not needed before g_
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] rng-random: NULL check not needed before g_free() |
Date: |
Thu, 7 Aug 2014 10:19:21 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 02, 2014 at 01:38:52PM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > g_free() is NULL-safe.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > Cc: Anthony Liguori <address@hidden>
> > Cc: Luiz Capitulino <address@hidden>
> > ---
> > backends/rng-random.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/backends/rng-random.c b/backends/rng-random.c
> > index 136499d..601d9dc 100644
> > --- a/backends/rng-random.c
> > +++ b/backends/rng-random.c
> > @@ -106,10 +106,7 @@ static void rng_random_set_filename(Object *obj, const
> > char *filename,
> > return;
> > }
> >
> > - if (s->filename) {
> > - g_free(s->filename);
> > - }
> > -
> > + g_free(s->filename);
> > s->filename = g_strdup(filename);
> > }
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
>
> Note there are a quite a few more instances of this anti-pattern.
> Coccinelle can find them, semantic patch appended. Beware, it can throw
> away comments in the conditional, which is usually not what we want.
>
>
> @@
> expression E;
> @@
> - if (E != NULL) {
> - g_free(E);
> - }
> + g_free(E);
address@hidden qemu]$ grep g_free -B 2 -r * |less
then try to search "/if.*NULL"
Not all can be found by this way, but many instances are found.
--
Amos.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 1/3] rng-random: NULL check not needed before g_free(),
Amos Kong <=