qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fst


From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat()
Date: Thu, 7 Aug 2014 09:50:43 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1

On 2014/8/6 20:30, Levente Kurusa wrote:
The function fstat() may fail, so check its return value.

Signed-off-by: zhanghailiang<address@hidden>
---
  hw/misc/ivshmem.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 768e528..5d939d2 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -324,7 +324,11 @@ static int check_shm_size(IVShmemState *s, int fd) {

      struct stat buf;

-    fstat(fd,&buf);
+    if (fstat(fd,&buf)<  0) {
+        fprintf(stderr, "ivshmem: exiting for fstat fd '%d' failed: %s\n",
+                fd, strerror(errno));

exiting for fstat?

I would go with something like this:

"ivshmem: exiting: fstat on fd %d failed: %s"

... or something among the lines.

Hmmm, this is more clear, i will change it.Thanks!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]