[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fst
From: |
Levente Kurusa |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat() |
Date: |
Wed, 6 Aug 2014 08:30:55 -0400 (EDT) |
> The function fstat() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
> hw/misc/ivshmem.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 768e528..5d939d2 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -324,7 +324,11 @@ static int check_shm_size(IVShmemState *s, int fd) {
>
> struct stat buf;
>
> - fstat(fd, &buf);
> + if (fstat(fd, &buf) < 0) {
> + fprintf(stderr, "ivshmem: exiting for fstat fd '%d' failed: %s\n",
> + fd, strerror(errno));
exiting for fstat?
I would go with something like this:
"ivshmem: exiting: fstat on fd %d failed: %s"
... or something among the lines.
Thanks!
Levente Kurusa