Re: [Qemu-devel] [PATCH buildfix for-2.1] libqos: Fix PC PCI endianness glitches

[Peter Maydell]

On 14 July 2014 16:38, Andreas Färber <address@hidden> wrote:
> The libqos implementation of io_read{b,w,l} and io_write{b,w,l} hooks
> was relying on qtest_mem{read,write}() respectively. With d81d410 (usb:
> improve ehci/uhci test) this resulted in assertion failures on ppc hosts:
>
>  ERROR:tests/usb-hcd-ehci-test.c:78:ehci_port_test: assertion failed: ((value 
> & mask) == (expect & mask))
>
>  ERROR:tests/usb-hcd-ehci-test.c:128:pci_uhci_port_2: assertion failed: 
> (pcibus != NULL)
>
>  ERROR:tests/usb-hcd-ehci-test.c:150:pci_ehci_port_2: assertion failed: 
> (pcibus != NULL)
>
> qtest_read{b,w,l,q}() and qtest_write{b,w,l,q}() had been introduced
> as endian-safe replacement for qtest_mem{read,write}() in I2C in
> 872536b (qtest: Add MMIO support). Use them for PCI as well.
>
> Cc: Anthony Liguori <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Fixes: c4efe1c qtest: add libqos including PCI support
> Fixes: d81d410 usb: improve ehci/uhci test
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  tests/libqos/pci-pc.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Applied to master, thanks.

-- PMM