qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-2.1 2/2] module: Don't complain when a module is


From: Andreas Färber
Subject: [Qemu-devel] [PATCH for-2.1 2/2] module: Don't complain when a module is absent
Date: Tue, 15 Jul 2014 16:04:26 +0200

The current implementation depends on a configure-time generated list of
block modules. When any of them is absent, module_load() emits a warning.

This is suboptimal because extracting code to modules was mainly done to
allow separate packaging of modules with intrusive dependencies. Absence
of optional packages then leads to absence of modules and an error
message, which users may recognize as new and report as error.

Cc: Fam Zheng <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Michael Tokarev <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
 util/module.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/util/module.c b/util/module.c
index 9fd3030..4bd4a94 100644
--- a/util/module.c
+++ b/util/module.c
@@ -209,9 +209,6 @@ static void module_load(module_init_type type)
                 break;
             }
         }
-        if (ret == -ENOENT) {
-            fprintf(stderr, "Can't find module: %s\n", *mp);
-        }
     }
 
     for (i = 0; i < ARRAY_SIZE(dirs); i++) {
-- 
1.8.4.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]