Re: [Qemu-devel] [PATCH v9 03/14] qcow2: Optimize bdrv_make_empty()

[Paolo Bonzini]

Il 05/07/2014 19:47, Max Reitz ha scritto:
> bdrv_make_empty() is currently only called if the current image
> represents an external snapshot that has been committed to its base
> image; it is therefore unlikely to have internal snapshots. In this
> case, bdrv_make_empty() can be greatly sped up by creating an empty L1
> table and dropping all data clusters at once by recreating the refcount
> structure accordingly instead of normally discarding all clusters.
>
> If there are snapshots, fall back to the simple implementation (discard
> all clusters).

How much of this code could be reused by bdrv_create?

Paolo