[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field |
Date: |
Mon, 07 Jul 2014 12:53:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/05/2014 11:47 AM, Max Reitz wrote:
> When a block job signals readiness, this is currently reported only
> through QMP. If qemu wants to use block jobs for internal tasks, there
> needs to be another way to correctly detect when a block job may be
> completed.
>
> For this reason, introduce a bool "ready" which is set when the block
> job may be completed.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> blockjob.c | 3 +++
> include/block/blockjob.h | 5 +++++
> qapi/block-core.json | 4 +++-
> 3 files changed, 11 insertions(+), 1 deletion(-)
>
> +++ b/qapi/block-core.json
> @@ -505,12 +505,14 @@
> #
> # @io-status: the status of the job (since 1.3)
> #
> +# @ready: true if the job may be completed (since 2.1)
Isn't this 2.2 now, or are you still shooting for calling this a bug fix
in 2.1 hard freeze?
Depending on the answer,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v9 11/14] iotests: Add _filter_qemu_img_map, (continued)
- [Qemu-devel] [PATCH v9 11/14] iotests: Add _filter_qemu_img_map, Max Reitz, 2014/07/05
- [Qemu-devel] [PATCH v9 12/14] iotests: Add test for backing-chain commits, Max Reitz, 2014/07/05
- [Qemu-devel] [PATCH v9 13/14] iotests: Add test for qcow2's bdrv_make_empty, Max Reitz, 2014/07/05
- [Qemu-devel] [PATCH v9 14/14] iotests: Omit length/offset test in 040 and 041, Max Reitz, 2014/07/05
- [Qemu-devel] [PATCH v9 04/14] blockjob: Introduce block_job_complete_sync(), Max Reitz, 2014/07/05
- [Qemu-devel] [PATCH v9 03/14] qcow2: Optimize bdrv_make_empty(), Max Reitz, 2014/07/05
- [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field, Max Reitz, 2014/07/05
- Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field,
Eric Blake <=
- [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report, Max Reitz, 2014/07/05