[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppr
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors |
|
Date: |
Fri, 02 May 2014 06:34:21 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 05/02/2014 05:26 AM, Markus Armbruster wrote:
> Using error_is_set(errp) that way can sweep programming errors under
> the carpet when we get called incorrectly with an error set.
>
> encrypted_bdrv_it() does it, because there's no way to make
> bdrv_iterate() break its loop. Actually safe, because qmp_cont()
> clears the error before the loop. Clean it up anyway: replace
> bdrv_iterate() by bdrv_next(), break the loop on error.
>
> Replace both occurences, for consistency.
s/occurences/occurrences/
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Fixing up the commit message typo is trivial and doesn't alter the
positive review.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 03/14] qmp: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 04/14] error: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 12/14] qemu-option: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 10/14] qga: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/05/02
- Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors,
Eric Blake <=
[Qemu-devel] [PATCH v3 02/14] qga: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 08/14] tests/qapi-schema: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 13/14] dump: Drop pointless error_is_set(), DumpState member errp, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 09/14] qapi: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 06/14] hmp: Guard against misuse of hmp_handle_error(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 11/14] qga: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02